-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(eval): support get_agent_async in adk eval
#4413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Align `adk eval` with `AgentEvaluator` by allowing agent modules to expose either `root_agent` or `get_agent_async`. - Make `cli_eval.get_root_agent` async and resolve agents from: - `agent.root_agent` - `agent.get_agent_async()` - Update `cli_tools_click.cli_eval` to call `get_root_agent` via `asyncio.run`. - Add unit tests for: - `root_agent` resolution - `get_agent_async` resolution - error when neither entrypoint is defined - Update CLI eval tests to mock async `get_root_agent` correctly.
Summary of ChangesHello @ftnext, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency in how Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully aligns adk eval with AgentEvaluator by adding support for get_agent_async to resolve the root agent. The implementation is clean, making get_root_agent asynchronous and correctly updating the call site. The unit tests are comprehensive and validate the new logic for both success and failure scenarios. I have one minor suggestion to improve code readability.
|
Hi @ftnext , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you fix lint errors by running autoformat.sh and also update the branch to main. |
|
Hi @ryanaiagent, thank you for the review! |
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
adk evalonly resolvedagent.root_agent, whileAgentEvaluatorsupports bothroot_agentandget_agent_async. This inconsistency caused valid agent modules (forAgentEvaluator) to fail in CLI evaluation.Solution:
Aligned
adk evalagent resolution withAgentEvaluatorby updating CLI loading logic to support both entry points:root_agentget_agent_asyncImplementation details:
get_root_agentincli_eval.pyasynchronous and added fallback resolution toget_agent_async.cli_tools_click.pyto callget_root_agentviaasyncio.run(...).Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
No manual E2E test was run for this PR.
Checklist
Additional context
This PR focuses on one scoped item from #4410: agent resolution parity between
adk evalandAgentEvaluator(root_agent/get_agent_async).