refactor: Code clean up in BaseAgent #848
Merged
+20
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_868418459
branch
3 times, most recently
from
92403c2 to
ab8369c
Compare
1. **Extracting Common Run Logic:** A new private method `run` is introduced to encapsulate the common setup and execution flow shared by both `runAsync` and `runLive`. This includes creating the `InvocationContext`, setting up tracing, and handling before/after callbacks.
2. **Reducing Duplication:** Both `runAsync` and `runLive` now call this new `run` method, passing their specific implementation (`runAsyncImpl` or `runLiveImpl`) as a function. This eliminates a significant amount of duplicated code.
3. **Minor Cleanups:**
* The `createInvocationContext` method now uses `parentContext.branch().filter(...).ifPresent(...)` for a more concise optional handling.
* An unnecessary `agentCallbacks == null` check is removed from `callCallback`, as the list should not be null.
PiperOrigin-RevId: 868646905
copybara-service
bot
force-pushed
the
test_868418459
branch
from
ab8369c to
8a1fffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Code clean up in BaseAgent
runis introduced to encapsulate the common setup and execution flow shared by bothrunAsyncandrunLive. This includes creating theInvocationContext, setting up tracing, and handling before/after callbacks.runAsyncandrunLivenow call this newrunmethod, passing their specific implementation (runAsyncImplorrunLiveImpl) as a function. This eliminates a significant amount of duplicated code.createInvocationContextmethod now usesparentContext.branch().filter(...).ifPresent(...)for a more concise optional handling.agentCallbacks == nullcheck is removed fromcallCallback, as the list should not be null.