Added 6 typescript snippets for LlmAgent #673
Conversation
| "@types/node": "^24.3.1", | ||
| "typescript": "^5.9.2" | ||
| }, | ||
| "@google/adk": "file:../adk-js/core", |
There was a problem hiding this comment.
Update this line before committing (after the release of the agent).
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
The best practice is to place package.json and tsconfig.json files at the root of the repository (same level as the examples directory.
There was a problem hiding this comment.
That is definitely true in general, but we will probably have many examples, each with different set of config files. I see a similar practice in the python folder where each example has its own requirements.txt.
There was a problem hiding this comment.
That makes sense. I will do the same then.
| const USER_ID = "test_user_789"; | ||
| const SESSION_ID_TOOL_AGENT = "session_tool_agent_ts"; | ||
| const SESSION_ID_SCHEMA_AGENT = "session_schema_agent_ts"; | ||
| const MODEL_NAME = "gemini-2.0-flash"; // Using flash for speed |
There was a problem hiding this comment.
I used gemini-2.0-flash to maintain consistency with the python snippets, but I am okay to update the version. What do you think? Should we keep things consistent with the python examples, or do our own thing and use the more updated model?
| ```typescript | ||
| // Example: Adding instructions | ||
| const capitalAgent = new LlmAgent({ | ||
| model: 'gemini-2.0-flash', |
| ```typescript | ||
| // Example: Defining the basic identity | ||
| const capitalAgent = new LlmAgent({ | ||
| model: 'gemini-2.0-flash', |
| "name": "adk-docs-examples", | ||
| "version": "1.0.0", | ||
| "description": "TS code examples for the ADK Documentation", | ||
| "main": "index.js", |
There was a problem hiding this comment.
There is no index.js file that serves as a central export. So, this field is misleading and should be removed.
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
That makes sense. I will do the same then.
| @@ -0,0 +1,24 @@ | |||
| { | |||
There was a problem hiding this comment.
I think the best practice is to add the package-lock.json file as well.
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "name": "adk-docs-examples", | |||
There was a problem hiding this comment.
lets rename it to "adk-llm_agent-ts-example" since we now agreed to add package.json per feature directory
| { | ||
| "name": "adk-docs-examples", | ||
| "version": "1.0.0", | ||
| "description": "TS code examples for the ADK Documentation", |
There was a problem hiding this comment.
For the same reason above, lets change the description to ADK TS example for LLM agent.
No description provided.