-
Notifications
You must be signed in to change notification settings - Fork 2.4k
correct model version nomenclature in Counting_Tokens.js #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi Gemini API Team! I noticed that Counting_Tokens.js references model versions like gemini-2.5-flash and gemini-3-pro-preview. However, according to the official Gemini Models documentation, the current available versions are in the 1.5 family. Using 2.5 in the example code causes a "Model not found" error for users trying to run the notebook. Changes: Updated MODEL_ID to gemini-1.5-flash. Updated comments to reflect current stable model naming conventions. This ensures the cookbook remains functional and accurate for the developer community.
Summary of ChangesHello @ChefitoGG, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Great catch on updating the model versions to gemini-1.5-flash! This is an important fix to ensure the cookbook examples run correctly for users. I've added a couple of suggestions to further improve the code's clarity and maintainability by fixing a small typo in the model list and adding a newline at the end of the file.
franciscoarturorivera371-cyber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submit the approval with the change..
|
I have manually applied the suggested changes from Gemini Code Assist. The code is updated and all conversations are resolved. Ready for your final review, @franciscoarturorivera371-cyber ! |
Hi Gemini API Team!
I noticed that Counting_Tokens.js references model versions like gemini-2.5-flash and gemini-3-pro-preview. However, according to the official Gemini Models documentation, the current available versions are in the 1.5 family.
Using 2.5 in the example code causes a "Model not found" error for users trying to run the notebook.
Changes:
Updated MODEL_ID to gemini-1.5-flash.
Updated comments to reflect current stable model naming conventions.
This ensures the cookbook remains functional and accurate for the developer community.