-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add JavaScript/TypeScript PDF processing quickstart (parity with PDF_Files.py) #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ved015, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request has a misleading title and description. It claims to add a JavaScript/TypeScript PDF processing quickstart, but the actual changes involve refactoring and improving a Python script for the Gemini Live API. Please update the PR title and description to reflect the actual changes.
The refactoring of Get_started_LiveAPI.py is a good improvement overall. The code is now better structured, with improved error handling, and efficiency. However, there are a few issues to address, including a user-specific settings file that should be removed, an inconsistency in the API key environment variable name, and some styling violations regarding whitespace. My detailed comments are below.
1677140 to
ddca890
Compare
|
@patrickloeber @linhkid awaiting your review on this |
franciscoarturorivera371-cyber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submit the change with the approval.
Giom-V
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ved015 Sorry for taking so long to review. The Js file seems fine and ready to be merged, but can you revert your changes on the live python script?
|
Hi @Giom-V thank you for reviewing i have made the changes pls check |
0008c0f to
da39f87
Compare
|
hi @Giom-V can we merge this now |
Closes #1076
Summary
This PR adds a JavaScript/TypeScript quickstart for PDF processing using the Gemini API, bringing feature parity with the existing Python example (
PDF_Files.py).Motivation
JS/TS users currently lack an official reference for handling PDFs with Gemini, despite this being a common use case. This PR reduces friction and aligns the JS/TS cookbook with Python quickstarts.
What’s Included
collaborated with @ishaanxgupta