Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyMJCF nested include tags relative to base model #417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guyazran
Copy link

@guyazran guyazran commented Aug 3, 2023

Addresses #418

@guyazran guyazran changed the title PyMJCF recursive include tags relative to base model PyMJCF nested include tags relative to base model Aug 5, 2023
@jonzamora
Copy link

jonzamora commented May 26, 2024

Hi @guyazran , did you happen to test this out before making your Pull Request here?

e.g. on the example you provided here: #418

I am also interested in composing XML files with PyMJCF which support nested include tags, and i'm hoping to revive this issue so things can be resolved for us and others.

@guyazran
Copy link
Author

guyazran commented May 28, 2024

Hi @jonzamora. Thanks for reviving this PR. It will make running with nested include tags much smoother.

I sent this PR in a long time ago, but I can definitely say that at the time of creating the PR and when I wrote "addresses #418" the example scene in that issue ran smoothly.

However, this might be a pointless effort because in another issue the creators said that they are working on a different solution #407. perhaps you should ping there and see how the alternative solution is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants