fixes for SolveIVP implementation #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the fix? |
soypat
commented
Jun 3, 2023
| @@ -46,10 +48,12 @@ func SolveIVP(p IVP, solver Integrator, stepsize, tend float64) (results []State | |||
| if nx == 0 { | |||
| return nil, errors.New("state vector length can not be equal to zero. Has ivp been set?") | |||
| } | |||
| solver.Init(p) | |||
There was a problem hiding this comment.
@kortschak Forgot to initialize the integrator. This was the pressing problem that caused the crash since it meant some fields were nil upon attempting to integrate.
There was a problem hiding this comment.
Thanks, that was my suspcion. Can you make a note of that in the commit message?
kortschak
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look. Fixes issue raised in mail group: https://groups.google.com/g/gonum-dev/c/_B0R3518KNI
also adds initial conditions as part of result vector returned by SolveIVP as that seems reasonably intuitive.