Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static/frontend: add a11y attributes to interactive elements #99

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

static/frontend: add a11y attributes to interactive elements #99

wants to merge 3 commits into from
+12 −10

Conversation

essjay05
Copy link

@essjay05 essjay05 commented Oct 25, 2024 •
edited
Loading

Updates interactive elements for unit-meta-details that were previously
not accessible via keyboard to have appropriate a11y attributes such as
roles, tabindex, and aria-live to improve the overall accessible
interactions with the meta- details and make it keyboard and
screenreader friendly.

Before screenshots:
-icons:
https://screenshot.googleplex.com/4eqbZ7ps58yCWwT
-tooltip:
https://screenshot.googleplex.com/6qzZ9wdtBpfXszy

After:
-icon screenshot updates:
https://screenshot.googleplex.com/7kbHJk4tYv2naQf
-tooltip screenshot updates:
https://screenshot.googleplex.com/8ZwutWMTS2FNkwy

Fixes b/283533035

@essjay05
fix(static/frontend): add a11y attributes to interactive elements
f2cd6cc 
Updates interactive elements for unit-meta-details that were
previously not accessible via keyboard to have appropriate
a11y attributes such as roles, tabindex, and aria-live to
improve the overall accessible interactions with the meta-
details and make it keyboard and screenreader friendly.

Fixes b/#283533035
@gopherbot
Copy link
Contributor

This PR (HEAD: f2cd6cc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jamal Carvalho:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: Hold+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@essjay05 essjay05 changed the title fix(static/frontend): add a11y attributes to interactive elements static/frontend: add a11y attributes to interactive elements Nov 6, 2024
@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@essjay05
static/frontend: adds missing end quotation mark
e699df9 
Updates previous fix to add missing end quotation
mark.

Fixes b/283533035
@gopherbot
Copy link
Contributor

This PR (HEAD: e699df9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@essjay05
static/frontend: generalizes valid/invalid tooltip aria-label
3f3fe4f 
Updates previous fix to generalize the aria-label for
the valid/invalid checkbox icon that triggers the
tooltip.

Fixes b/283533035
@gopherbot
Copy link
Contributor

This PR (HEAD: 3f3fe4f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@essjay05 @gopherbot