-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static/shared: add titles to social media links #98
base: master
Are you sure you want to change the base?
Conversation
Previously the social media links did not have a tool tip that would appear on hovering over the icons to notify the user what the purpose of the link was for. This change adds the aria-label value as a title to appear as a tooltip on hovering the icon. Fixes b/#297941481
This PR (HEAD: 0a104cb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621840. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621840. |
Message from Joy Serquina (xWF): Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621840. |
Message from Jonathan Amsterdam: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/621840. |
Message from Denis Bowen (xWF): Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/621840. |
Message from Nooras Saba: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/621840. |
Message from Nooras Saba: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621840. |
Message from Joy Serquina (xWF): Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621840. |
Previously the social media links did not have a tool tip that would
appear on hovering over the icons to notify the user what the
purpose of the link was for. This change adds the aria-label value as
a title to appear as a tooltip on hovering the icon.
Before screencast:
https://screencast.googleplex.com/cast/NTQ2OTc5OTQwNzY4MTUzNnw0MDRlODgxYi03ZA
After screencast:
https://screencast.googleplex.com/cast/NTgzMTQ0NTAzMjQ2ODQ4MHw0Mjg3NGRlNS01NA
Bug b/297941481
Fixes golang/go#53565