Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static/shared: add titles to social media links #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

essjay05
Copy link

@essjay05 essjay05 commented Oct 24, 2024

Previously the social media links did not have a tool tip that would
appear on hovering over the icons to notify the user what the
purpose of the link was for. This change adds the aria-label value as
a title to appear as a tooltip on hovering the icon.

Before screencast:
https://screencast.googleplex.com/cast/NTQ2OTc5OTQwNzY4MTUzNnw0MDRlODgxYi03ZA

After screencast:
https://screencast.googleplex.com/cast/NTgzMTQ0NTAzMjQ2ODQ4MHw0Mjg3NGRlNS01NA

Bug b/297941481

Fixes golang/go#53565

Previously the social media links did not have a tool
tip that would appear on hovering over the icons to
notify the user what the purpose of the link was for.
This change adds the aria-label value as a title to
appear as a tooltip on hovering the icon.

Fixes b/#297941481
@gopherbot
Copy link
Contributor

This PR (HEAD: 0a104cb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621840.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 2: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/621840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Denis Bowen (xWF):

Patch Set 2: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/621840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 3: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/621840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621840.
After addressing review feedback, remember to publish your drafts!

@essjay05 essjay05 changed the title fix(static/shared): add titles to social media links static/shared: add titles to social media links Nov 6, 2024
@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621840.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/website: A11y, links need discernible text
2 participants