-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static/frontend: increase percentage of mask-image start #97
base: master
Are you sure you want to change the base?
static/frontend: increase percentage of mask-image start #97
Conversation
The exisiting percentage of where the mask-image linear-gradient starts currently overlaps some links when text-spacing is applied and therefore decreases the color-contrast ratio of the link making the text less accessible. This change increases the percentage and thus moves the gradient to be closer to the end of the container and less likely to overlap text and links. Fixes b/365624081 [Before screenshot](https://screenshot.googleplex.com/By9T6ZKwv6wxPue) [After screenshot](https://screenshot.googleplex.com/Ad4J3683xC9sQdH)
This PR (HEAD: f20d142) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621839. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
Message from Joy Serquina (xWF): Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
Message from Denis Bowen (xWF): Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
Message from Joy Serquina (xWF): Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
Message from Nooras Saba: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
Message from Nooras Saba: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
Message from Jonathan Amsterdam: Patch Set 3: Hold+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
Message from Joy Serquina (xWF): Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621839. |
The existing percentage of where the mask-image linear-gradient starts
currently overlaps some links when text-spacing is applied and therefore
decreases the color-contrast ratio of the link making the text less
accessible. This change increases the percentage and thus moves the
gradient to be closer to the end of the container and less likely to
overlap text and links.
Before screenshot:
https://screenshot.googleplex.com/By9T6ZKwv6wxPue)
After screenshot:
https://screenshot.googleplex.com/Ad4J3683xC9sQdH)
Fixes b/365624081