Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static/frontend: add search aria-describedby #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

essjay05
Copy link

@essjay05 essjay05 commented Nov 5, 2024

Currently the search input aria-label is static and when
focused on by a screen reader, the screen reader does
not read the search tip found below the input. This
change checks the .TipIndex value and if it
matches adds the id=SearchTipContent which the input's
aria-describedby is attached to, thus allowing the visible
tip/description to be read as supplemental info after the
input's existing aria-label.

Before screenshot:
https://screenshot.googleplex.com/AkAmQ69s4R3NsZS

After screenshot:
https://screenshot.googleplex.com/94MwK6bXpSBE6Gr

Fixes b/283297190

Currently the search input aria-label is static and
when focused on by a screen reader, the screen reader
does not read the search tip found below the input.
This change checks the .TipIndex value and if it
matches adds the id=SearchTipContent which the input's
aria-describedby is attached to, thus allowing the
visible tip/description to be read as supplemental
info after the input's existing aria-label.

Fixes b/#283297190
@gopherbot
Copy link
Contributor

This PR (HEAD: 2ebbcc3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/625235.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!

@essjay05 essjay05 changed the title fix(static/frontend): add search aria-describedby static/frontend: add search aria-describedby Nov 6, 2024
@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants