-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static/frontend: add search aria-describedby #102
base: master
Are you sure you want to change the base?
Conversation
Currently the search input aria-label is static and when focused on by a screen reader, the screen reader does not read the search tip found below the input. This change checks the .TipIndex value and if it matches adds the id=SearchTipContent which the input's aria-describedby is attached to, thus allowing the visible tip/description to be read as supplemental info after the input's existing aria-label. Fixes b/#283297190
This PR (HEAD: 2ebbcc3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/625235. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/625235. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/625235. |
Message from Joy Serquina (xWF): Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/625235. |
Message from Jonathan Amsterdam: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/625235. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/625235. |
Message from Joy Serquina (xWF): Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/625235. |
Currently the search input aria-label is static and when
focused on by a screen reader, the screen reader does
not read the search tip found below the input. This
change checks the .TipIndex value and if it
matches adds the id=SearchTipContent which the input's
aria-describedby is attached to, thus allowing the visible
tip/description to be read as supplemental info after the
input's existing aria-label.
Before screenshot:
https://screenshot.googleplex.com/AkAmQ69s4R3NsZS
After screenshot:
https://screenshot.googleplex.com/94MwK6bXpSBE6Gr
Fixes b/283297190