-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: check for MPTCP in DialTCP and ListenTCP #70501
Conversation
This PR (HEAD: 3414305) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/630715. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Matthieu Baerts: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Damien Neil: Patch Set 2: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-21T20:00:48Z","revision":"c94d44f9365546273462feac35a8beee9e481b18"} Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Setting GODEBUG=multipathtcp= [1] has no effects on apps using ListenTCP or DialTCP directly. According to the documentation, these functions are supposed to act like Listen and Dial respectively: ListenTCP acts like Listen for TCP networks. DialTCP acts like Dial for TCP networks. So when reading this, I think we should expect GODEBUG=multipathtcp= to act on these functions as well. Also, since golang#69016, MPTCP is used by default (if supported) with TCP listeners. Similarly, when ListenTCP is used directly, MPTCP is unexpectedly not used. It is strange to have a different behaviour. So now, ListenTCP and DialTCP also check for MPTCP. Those are the exact same checks that are done in dial.go, see Listen and dialSingle. [1] https://pkg.go.dev/net#Dialer.SetMultipathTCP Fixes golang#70500
3414305
to
69a31a1
Compare
Message from Damien Neil: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-aliastypeparams has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
This PR (HEAD: 69a31a1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/630715. Important tips:
|
Message from Matthieu Baerts: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Ian Lance Taylor: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-21T20:47:05Z","revision":"8be33f0cf5c6416c62fd0873a951fdeca7630290"} Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Ian Lance Taylor: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-21T21:13:51Z","revision":"8be33f0cf5c6416c62fd0873a951fdeca7630290"} Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/630715. |
Setting GODEBUG=multipathtcp= [1] has no effects on apps using ListenTCP or DialTCP directly. According to the documentation, these functions are supposed to act like Listen and Dial respectively: ListenTCP acts like Listen for TCP networks. DialTCP acts like Dial for TCP networks. So when reading this, I think we should expect GODEBUG=multipathtcp= to act on these functions as well. Also, since #69016, MPTCP is used by default (if supported) with TCP listeners. Similarly, when ListenTCP is used directly, MPTCP is unexpectedly not used. It is strange to have a different behaviour. So now, ListenTCP and DialTCP also check for MPTCP. Those are the exact same checks that are done in dial.go, see Listen and dialSingle. [1] https://pkg.go.dev/net#Dialer.SetMultipathTCP Fixes #70500 Change-Id: I646431a74571668e505493fa8c1b2206bf30ed09 GitHub-Last-Rev: 69a31a1 GitHub-Pull-Request: #70501 Reviewed-on: https://go-review.googlesource.com/c/go/+/630715 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/630715 has been merged. |
Setting GODEBUG=multipathtcp= [1] has no effects on apps using
ListenTCP or DialTCP directly.
According to the documentation, these functions are supposed to act like
Listen and Dial respectively:
So when reading this, I think we should expect GODEBUG=multipathtcp= to
act on these functions as well.
Also, since #69016, MPTCP is used by default (if supported) with TCP
listeners. Similarly, when ListenTCP is used directly, MPTCP is
unexpectedly not used. It is strange to have a different behaviour.
So now, ListenTCP and DialTCP also check for MPTCP. Those are the exact
same checks that are done in dial.go, see Listen and dialSingle.
[1] https://pkg.go.dev/net#Dialer.SetMultipathTCP
Fixes #70500