-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os/signal: check int type of signal using reflection #70368
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 3a8a7ca) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628275. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/628275. |
Message from Qizhou Guo: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/628275. |
Message from Alan Donovan: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/628275. |
This PR (HEAD: 35c8f70) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628275. Important tips:
|
This PR (HEAD: 3204c91) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628275. Important tips:
|
Message from Qizhou Guo: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/628275. |
Message from Cherry Mui: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/628275. |
Message from Qizhou Guo: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/628275. |
The current implementation of the signum function only checks if os.Signal is
of type syscall.Signal, then converts it to int. However, golang.org/x/sys
defines its own Signal type for Windows at
https://cs.opensource.google/go/x/sys/+/refs/tags/v0.27.0:windows/syscall_windows.go;l=1472
This causes the signum function and the higher-level signal.Notify function
to fail to recognize signals like windows.SIGINT defined in golang.org/x/sys.
One possible approach is to specifically handle windows.Signal in signum,
but it's unreasonable to make go/src reference golang.org/x/sys.
Another approach is to make windows.Signal directly type alias to
syscall.Signal in golang.org/x/sys, but windows.Signal is fundamentally
different from syscall.Signal (the signals map is different), which is also
not feasible.
Therefore, this PR attempts to use reflection to obtain the possible int
type, to handle this special case for Windows.
Fixes #70369