Replace aws-sdk-go v1 with aws-sdk-go-v2 #1189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS announced that aws-sdk-go v1 entered the maintenance mode and will reach end of support by July 31, 2025. As many Go projects use go-migrate internally they still references the aws-sdk-go v1. Even go-migrate itself has both versions in the go.mod. This PR fixes it. https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/
|
github.com/snowflakedb/gosnowflake was updated to v1.11.2 in order to resolve this issue. github.com/aws/aws-sdk-go-v2/feature/s3/[email protected]/download.go:439:27:
invalid operation: resp.ContentLength > 0 (mismatched types *int64 and untyped int) |
serprex
reviewed
Nov 29, 2024
source/aws_s3/s3.go
Outdated
| driver := &s3Driver{ | ||
| config: config, | ||
| s3client: s3client, | ||
| migrations: source.NewMigrations(), | ||
| ctx: ctx, |
There was a problem hiding this comment.
Better off not storing ctx in s3Driver, instead pass it directly to loadMigrations
There was a problem hiding this comment.
Thank you for your feedback, Philip! I've updated the sources accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS announced that aws-sdk-go v1 entered the maintenance mode and will reach end of support by July 31, 2025. As many Go projects use go-migrate internally they still references the aws-sdk-go v1. Even go-migrate itself has both versions in the go.mod. This PR fixes it.
https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/
related #739