Make crypto tests work with OpenSSL 3.0 under FIPS #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/openssl-3.0.x-fixes
branch
from
b1a0ee7
to
c91e7a7
Compare
|
@dbenoit17 in the latest revision I've replaced the RSA test key with newly generated 2048-bit key, so the majority of encryption/signing tests are not skipped. |
ueno
force-pushed
the
wip/openssl-3.0.x-fixes
branch
2 times, most recently
from
5e696d1
to
faa422f
Compare
ueno
force-pushed
the
wip/openssl-3.0.x-fixes
branch
3 times, most recently
from
bf6df8f
to
764e38c
Compare
There are a few restrictions enforced when OpenSSL 3.0 is used under FIPS mode, that are incompatible with the Go tests, namely: - For creating signature, encrypting, and decrypting, RSA key size must be equal to or longer than 2048 bits - For verifying signature, RSA key size must be equal to or longer than 1024 bits - PKCS#1 v1.5 is not supported for encryption and decryption (signing and verification are still allowed) This either skips the relevant tests or increases key size used for testing. Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/openssl-3.0.x-fixes
branch
from
764e38c
to
2aae08c
Compare
derekparker
reviewed
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few restrictions enforced when OpenSSL 3.0 is used under FIPS mode, that are incompatible with the Go tests, namely:
This either skips the relevant tests or increases key size used for testing.
This should fix the test failures in
cryptotests as mentioned in golang-fips/openssl#25.