Pass SourcePackageInstance to gowrap generator to avoid redundant package load#158
Open
jerenkrantz wants to merge 1 commit intogojuno:masterfrom
Open
Conversation
…kage load gowrap's generator.Options already supports a SourcePackageInstance field to accept a pre-loaded *packages.Package, but minimock was not using it. This caused NewGenerator() to call pkg.Load() a second time for the same source package on every interface, spawning a redundant go list subprocess each time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jerenkrantz
requested review from
auvn,
hexdigest,
regeda,
superstas and
zcolleen
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generator.Optionshas aSourcePackageInstancefield that acceptsa pre-loaded
*packages.Package, skipping the redundantpkg.Load()callinside
NewGenerator()run()but wasn't passing itthrough, causing gowrap to load it again for every interface
Motivation
Each
pkg.Load()call spawns ago listsubprocess. For projects generatingmany mocks, eliminating this redundant load per interface reduces wall time
by ~35% in testing.
This PR description was written by Claude Code, not a human.
🤖 Generated with Claude Code