-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix(i18n): improve Korean translation of FULL_NAME #22701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: InGyu Moon <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22701 +/- ##
===========================================
+ Coverage 45.36% 65.85% +20.48%
===========================================
Files 244 1073 +829
Lines 13333 116100 +102767
Branches 2719 2931 +212
===========================================
+ Hits 6049 76452 +70403
- Misses 6983 35403 +28420
- Partials 301 4245 +3944
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the Korean translation of the "FULL_NAME" label in the user profile section by changing it from "성과 이름" (last name and first name) to "이름(성명)" (name/full name), which is more natural and less confusing in Korean.
Key Changes
- Updated the Korean translation for PROFILE.FULL_NAME to use a more natural expression
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "USER_NAME": "사용자 이름", | ||
| "EMAIL": "이메일", | ||
| "FULL_NAME": "성과 이름", | ||
| "FULL_NAME": "이름(성명)", |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation at line 108 has been updated to "이름(성명)", but the placeholder text at line 100 still contains the phrase "성과 이름을 포함한" (including last name and first name), which references the old translation concept. For consistency, the placeholder text should also be updated to align with the new translation approach.
Comprehensive Summary of your change
This PR updates the Korean translation of the "FULL_NAME" label in the user creation form
from "성과 이름" to "이름(성명)", as the current expression is unnatural and potentially confusing in Korean.
No functional changes are included.
Issue being fixed
N/A (small i18n improvement; no issue created)
Please indicate you've done the following: