Skip to content

Conversation

@InGyu-Moon
Copy link

@InGyu-Moon InGyu-Moon commented Jan 3, 2026

Comprehensive Summary of your change

This PR updates the Korean translation of the "FULL_NAME" label in the user creation form
from "성과 이름" to "이름(성명)", as the current expression is unnatural and potentially confusing in Korean.

No functional changes are included.

Issue being fixed

N/A (small i18n improvement; no issue created)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. (release-note/ignore-for-release)
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@InGyu-Moon InGyu-Moon requested a review from a team as a code owner January 3, 2026 11:55
@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.85%. Comparing base (c8c11b4) to head (00d9b1a).
⚠️ Report is 612 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22701       +/-   ##
===========================================
+ Coverage   45.36%   65.85%   +20.48%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116100   +102767     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76452    +70403     
- Misses       6983    35403    +28420     
- Partials      301     4245     +3944     
Flag Coverage Δ
unittests 65.85% <ø> (+20.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 987 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the Korean translation of the "FULL_NAME" label in the user profile section by changing it from "성과 이름" (last name and first name) to "이름(성명)" (name/full name), which is more natural and less confusing in Korean.

Key Changes

  • Updated the Korean translation for PROFILE.FULL_NAME to use a more natural expression

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"USER_NAME": "사용자 이름",
"EMAIL": "이메일",
"FULL_NAME": "성과 이름",
"FULL_NAME": "이름(성명)",
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation at line 108 has been updated to "이름(성명)", but the placeholder text at line 100 still contains the phrase "성과 이름을 포함한" (including last name and first name), which references the old translation concept. For consistency, the placeholder text should also be updated to align with the new translation approach.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants