-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix(ui): avoid duplicate RUN in build history #22685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AllForNothing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22685 +/- ##
==========================================
+ Coverage 45.36% 46.58% +1.21%
==========================================
Files 244 252 +8
Lines 13333 14276 +943
Branches 2719 2932 +213
==========================================
+ Hits 6049 6650 +601
- Misses 6983 7268 +285
- Partials 301 358 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@Tusharjamdade Please fix the CI. |
Signed-off-by: Tushar Jamdade <[email protected]>
e6584d7 to
2208c5f
Compare
stonezdj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint error in the UI code.
Signed-off-by: Tusharjamdade <[email protected]>
Signed-off-by: Tusharjamdade <[email protected]>
|
Hi @stonezdj, I’ve updated the code. Please take a look. |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Fixes duplicated RUN instructions shown in the build history UI for images built with BuildKit.
Adds a guard to avoid rewriting /bin/sh -c when the command is already prefixed with RUN.
Issue being fixed
Fixes #22664
Please indicate you've done the following: