Skip to content

Conversation

@Tusharjamdade
Copy link

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Fixes duplicated RUN instructions shown in the build history UI for images built with BuildKit.
Adds a guard to avoid rewriting /bin/sh -c when the command is already prefixed with RUN.

Issue being fixed

Fixes #22664

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.58%. Comparing base (c8c11b4) to head (6afbd72).
⚠️ Report is 613 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #22685      +/-   ##
==========================================
+ Coverage   45.36%   46.58%   +1.21%     
==========================================
  Files         244      252       +8     
  Lines       13333    14276     +943     
  Branches     2719     2932     +213     
==========================================
+ Hits         6049     6650     +601     
- Misses       6983     7268     +285     
- Partials      301      358      +57     
Flag Coverage Δ
unittests 46.58% <100.00%> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...additions/build-history/build-history.component.ts 86.95% <100.00%> (+1.95%) ⬆️

... and 177 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chlins
Copy link
Member

chlins commented Jan 5, 2026

@Tusharjamdade Please fix the CI.

@stonezdj stonezdj added the release-note/update Update or Fix label Jan 5, 2026
Copy link
Contributor

@stonezdj stonezdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint error in the UI code.

Signed-off-by: Tusharjamdade <[email protected]>
Signed-off-by: Tusharjamdade <[email protected]>
@Tusharjamdade
Copy link
Author

Hi @stonezdj, I’ve updated the code. Please take a look.

@Tusharjamdade Tusharjamdade requested a review from stonezdj January 6, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUN instrument is not displayed correctly

6 participants