Skip to content

Conversation

@Tusharjamdade
Copy link

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Addresses i18n issues in the max upstream connection configuration by adding missing translations and replacing a hardcoded placeholder.

Issue being fixed

Fixes #22677

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tusharjamdade Thanks for your contribution,

Please update with the suggested changes.

Signed-off-by: Tushar Jamdade <[email protected]>
@Tusharjamdade
Copy link
Author

Hi @bupd, I’ve updated the changes as per the review. Please take a look.

@Tusharjamdade Tusharjamdade requested a review from bupd December 26, 2025 16:00
Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as requested, update for all i18n keys.

Thanks

"PROXY_CACHE_ENDPOINT": "Proxy Cache Endpoint"
"PROXY_CACHE_ENDPOINT": "Proxy Cache Endpoint",
"CONNECTION_LIMIT": "Connection limit",
"PROXY_CACHE_MAX_UPSTREAM_CONN_TIP": "Maximum number of concurrent connections to the upstream server",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"PROXY_CACHE_MAX_UPSTREAM_CONN_TIP": "Maximum number of concurrent connections to the upstream server",
"PROXY_CACHE_MAX_UPSTREAM_CONN_TIP": "The max connection to the upstream registry for this proxy cache project, if -1, then there is no limit",

update for the i18n files

"PROXY_CACHE_ENDPOINT": "Proxy Cache Endpoint",
"CONNECTION_LIMIT": "Connection limit",
"PROXY_CACHE_MAX_UPSTREAM_CONN_TIP": "Maximum number of concurrent connections to the upstream server",
"PROXY_CACHE_MAX_UPSTREAM_CONN_PLACEHOLDER": "Enter upstream connection limit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"PROXY_CACHE_MAX_UPSTREAM_CONN_PLACEHOLDER": "Enter upstream connection limit"
"PROXY_CACHE_MAX_UPSTREAM_CONN_PLACEHOLDER": "Please enter -1 or an integer greater than 0."

update for all the i18n files

@reasonerjt
Copy link
Contributor

Do you need to put English messages to non-English locale files?

@reasonerjt
Copy link
Contributor

@bupd could you double check?

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.54%. Comparing base (c8c11b4) to head (04dfe6c).
⚠️ Report is 611 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22684       +/-   ##
===========================================
+ Coverage   45.36%   68.54%   +23.17%     
===========================================
  Files         244      821      +577     
  Lines       13333   101822    +88489     
  Branches     2719        0     -2719     
===========================================
+ Hits         6049    69797    +63748     
- Misses       6983    28144    +21161     
- Partials      301     3881     +3580     
Flag Coverage Δ
unittests 68.54% <ø> (+23.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1053 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix i18n issues for max_upstream_conn feature

6 participants