-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix(i18n): resolve missing keys and localize max upstream connection placeholder #22684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tushar Jamdade <[email protected]>
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tusharjamdade Thanks for your contribution,
Please update with the suggested changes.
src/portal/src/app/base/left-side-nav/projects/create-project/create-project.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: Tushar Jamdade <[email protected]>
|
Hi @bupd, I’ve updated the changes as per the review. Please take a look. |
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as requested, update for all i18n keys.
Thanks
| "PROXY_CACHE_ENDPOINT": "Proxy Cache Endpoint" | ||
| "PROXY_CACHE_ENDPOINT": "Proxy Cache Endpoint", | ||
| "CONNECTION_LIMIT": "Connection limit", | ||
| "PROXY_CACHE_MAX_UPSTREAM_CONN_TIP": "Maximum number of concurrent connections to the upstream server", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "PROXY_CACHE_MAX_UPSTREAM_CONN_TIP": "Maximum number of concurrent connections to the upstream server", | |
| "PROXY_CACHE_MAX_UPSTREAM_CONN_TIP": "The max connection to the upstream registry for this proxy cache project, if -1, then there is no limit", |
update for the i18n files
| "PROXY_CACHE_ENDPOINT": "Proxy Cache Endpoint", | ||
| "CONNECTION_LIMIT": "Connection limit", | ||
| "PROXY_CACHE_MAX_UPSTREAM_CONN_TIP": "Maximum number of concurrent connections to the upstream server", | ||
| "PROXY_CACHE_MAX_UPSTREAM_CONN_PLACEHOLDER": "Enter upstream connection limit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "PROXY_CACHE_MAX_UPSTREAM_CONN_PLACEHOLDER": "Enter upstream connection limit" | |
| "PROXY_CACHE_MAX_UPSTREAM_CONN_PLACEHOLDER": "Please enter -1 or an integer greater than 0." |
update for all the i18n files
|
Do you need to put English messages to non-English locale files? |
|
@bupd could you double check? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22684 +/- ##
===========================================
+ Coverage 45.36% 68.54% +23.17%
===========================================
Files 244 821 +577
Lines 13333 101822 +88489
Branches 2719 0 -2719
===========================================
+ Hits 6049 69797 +63748
- Misses 6983 28144 +21161
- Partials 301 3881 +3580
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Addresses i18n issues in the max upstream connection configuration by adding missing translations and replacing a hardcoded placeholder.
Issue being fixed
Fixes #22677
Please indicate you've done the following: