Skip creating core/jobservice secrets when using external secrets #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all secret fields are sourced from external secrets (e.g., via ExternalSecrets operator), the chart was still creating empty Secret objects with only metadata. This caused conflicts and confusion. Added helper functions to determine if secrets should be created: - harbor.core.createSecret - harbor.jobservice.createSecret The secrets are now only created when at least one data field would be populated. If all fields use existingSecret references, the Secret object is skipped entirely.
Author
|
Also now I am thinking, we probably need to deal with annotations as well? Or is cksum of 0 fine? At least local templating worked fine. |
Collaborator
|
Hi @eidmantas , I would take the
Could you elaborate more in your scenario what is |
Author
|
Hey @MinerYang , for example storing secrets in an external engine for all, and then using ExternalSecrets in k8s, or some other mechanism to create k8s secrets and use those instead of the helm generated ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed that when you move all secrets to an external (non-helm generated) source - the secrets still remain and cause confusion for peers.
I thought about adding a helper function and if everything is moved, then we do not create a secret at all.