Fix harbor-cli project logs returning no output #587
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Tak <[email protected]>
DrowsyWings
force-pushed
the
fix/project-logs-no-output
branch
from
8a5e2dc to
9102a6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
harbor project logssubcommand so that it displays project-specific audit logs.Problem
The
harbor project logssubcommand returned empty output even when audit logs existed for the project.Solution
Previously it was using the v1 version of log functions
This change updates the logic to use v2 functions and corresponding types to v2 (similar to
harbor logscommand )Tested it against demo.goharbor.io instance which have existing audit logs
Fixes #586