-
Notifications
You must be signed in to change notification settings - Fork 86
Proposal: Arm64 Support and Multi-Architecture Image Publishing for Harbor #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ranimandepudi bitnami has already built arm images for Harbor, it is open-sourced in https://github.com/bitnami/containers/tree/main/bitnami, and images is available in https://hub.docker.com/r/bitnami/harbor-core, maybe you could reference it. |
Thanks for sharing this @stonezdj ! Just to clarify — the changes I proposed in the PR are focused solely on enabling multi-arch Docker image builds without impacting existing functionality. Since Photon OS already supports both amd64 and arm64, my patch preserves the current behavior while adding support for Arm builds in a clean and upstream-friendly way. |
|
@ranimandepudi can you link the PR in the main repository for the changes! |
|
@ranimandepudi can you please fix your DCO |
OrlinVasilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a MUST have!
6e1fe36 to
a044855
Compare
|
@OrlinVasilev Thank you for your support! I have made the updates based on your comments. Please let me know if any further changes are needed. |
65692f9 to
204bad3
Compare
|
@wy65701436 — Could you please review it and let me know if anything needs to be updated ? I have the CI pipeline changes in my local, can push them once this is tested !! |
|
@wy65701436 @Vad1mo |
|
Hi @ranimandepudi , By reviewing this proposal and the PR. Besides what we have discussed above(though some of them are still unresolved), I have a few other details that might need mentioned here
|
If we release it as sandbox and people use it, I think we can address if any challenges come up ! But I can add the phase 1 and 2 plan in the proposal |
For sandboxing, you can fork Harbor and release it in your forked repo. I suggest we need to ensure the quality of the change before it's merged and released. |
|
Trilled to have also arm64 image, then I can switch from Bitnami chart |
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I suggest we divide this task into two phases. In Phase 1, we will update the relevant build scripts and introduce a new pipeline for ARM. This will allow us to run unit tests, end-to-end tests, and ensure the entire workflow operates on ARM. However, no deliverables will be shipped to Harbor users during this phase; users who wish to try it in advance can build and test it locally. Once Phase 1 is complete, we will proceed to Phase 2, where we will focus on building both ARM and AMD images and releasing them to users, including the necessary updates for docker-compose and Helm. How do you think? @ranimandepudi |
|
I had an offline discussion with @chlins — we're aligned to move forward with Harbor ARM support. I have just two general comments on the proposal:
Let me know if this makes sense or needs further refinement. |
@ranimandepudi Can we address those comments so we can move forward with the implementation? Please let me know if you have any concerns. |
|
@stonezdj @MinerYang @wy65701436 @OrlinVasilev |
|
@ranimandepudi Please fix the DCO as well. |
a46b7f9 to
32419e4
Compare
|
@chlins @OrlinVasilev @wy65701436 @OrlinVasilev I have updated the PR according to the comments. Let me know if anything to be updated !! Thanks |
chlins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
32419e4 to
bb1f35f
Compare
|
@ranimandepudi please help to fix the DCO, thanks. |
wy65701436
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Rani Chowdary Mandepudi <[email protected]> Signed-off-by: Mandepudi Rani Chowdary <[email protected]>
Signed-off-by: Rani Chowdary Mandepudi <[email protected]> Signed-off-by: Mandepudi Rani Chowdary <[email protected]>
Signed-off-by: Rani Chowdary Mandepudi <[email protected]> Signed-off-by: Mandepudi Rani Chowdary <[email protected]>
…espaces, CI sequencing Signed-off-by: Rani Chowdary Mandepudi <[email protected]> Signed-off-by: Mandepudi Rani Chowdary <[email protected]>
Signed-off-by: Rani Chowdary Mandepudi <[email protected]> Signed-off-by: Mandepudi Rani Chowdary <[email protected]>
bb1f35f to
dddd685
Compare
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Tested and confirmed: Harbor functions fully on both Arm64 and Amd64 platforms, including the UI, API, registry, and multi-architecture artifact handling.
As the author of this contribution from Arm, I welcome any feedback, collaboration, or questions from the Harbor community.
Thank you to the community for your continued support. Arm ambassadors are always ready to support Harbor.
Related PR in the main Harbor repository: goharbor/harbor#21982