Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net/ghttp/): fix the issue of using application/octet stream to upload large files causing excessive memory and crashing #3693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(net/ghttp/): fix the issue of using application/octet stream to upload large files causing excessive memory and crashing #3693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions net/ghttp/ghttp_request_param.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,12 @@ func (r *Request) parseBody() {
if r.parsedBody {
return
}

// If it's binary data, it does not need to be parsed.
if contentType := r.Header.Get("Content-Type"); contentType == "" || gstr.Contains(contentType, "octet-stream") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • condition contentType == "" might be removed?
  • missing associated unit testing case for the changes.

return
}

r.parsedBody = true
// There's no data posted.
if r.ContentLength == 0 {
Expand Down Expand Up @@ -273,6 +279,11 @@ func (r *Request) parseForm() {
err error
repeatableRead = true
)
// If it's binary data, it does not need to be parsed.
if gstr.Contains(contentType, "octet-stream") {
return
}

if gstr.Contains(contentType, "multipart/") {
// To avoid big memory consuming.
// The `multipart/` type form always contains binary data, which is not necessary read twice.
Expand Down
Loading