♻️Refactor: replace treePath with treePathHash in DefaultCtx to reduce memory usage #3368
+34
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes refactor how tree paths are managed across several modules by replacing string-based keys with integer-based keys throughout the routing stack. In the core application and router files, the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant D as DefaultCtx
participant A as App
participant TS as TreeStack
C->>D: Send Request
D->>D: Compute treePathHash from detectionPath
D->>A: Invoke route matching (next)
A->>TS: Retrieve routes using treePathHash
alt Key exists
TS-->>A: Return matching routes
else Fallback
A->>TS: Retrieve routes using fallback key 0
TS-->>A: Return fallback routes
end
A-->>D: Return matching result
D-->>C: Final Response
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3368 +/- ##
==========================================
- Coverage 83.71% 83.71% -0.01%
==========================================
Files 118 118
Lines 11722 11721 -1
==========================================
- Hits 9813 9812 -1
Misses 1482 1482
Partials 427 427
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ksw2000
requested review from
gaby,
sixcolors,
ReneWerner87 and
efectn
and removed request for
a team
ReneWerner87
approved these changes
Mar 25, 2025
10 tasks
ksw2000
changed the title
ksw2000
changed the title
ksw2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the default context, the 3-byte-long
treePathcan be encoded as an int. Therefore, reduce the size ofDefaultCtxandtreeStackType of change
Please delete options that are not relevant.
Checklist
Before you submit your pull request, please make sure you meet these requirements:
/docs/directory for Fiber's documentation.