-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add notes about C# differences in Variant constructors #98499
Open
tetrapod00
wants to merge
1
commit into
godotengine:master
Choose a base branch
from
tetrapod00:docs-dotnet-constructor-differences
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Docs: Add notes about C# differences in Variant constructors #98499
tetrapod00
wants to merge
1
commit into
godotengine:master
from
tetrapod00:docs-dotnet-constructor-differences
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
reviewed
Oct 24, 2024
tetrapod00
force-pushed
the
docs-dotnet-constructor-differences
branch
from
October 24, 2024 23:07
e41a500
to
7f3ee84
Compare
tetrapod00
force-pushed
the
docs-dotnet-constructor-differences
branch
from
October 25, 2024 16:09
7f3ee84
to
4e8ab9d
Compare
Mickeon
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and one-ah more thing-
tetrapod00
force-pushed
the
docs-dotnet-constructor-differences
branch
from
October 27, 2024 20:24
4e8ab9d
to
c51cdaf
Compare
mhilbrunner
approved these changes
Oct 28, 2024
AThousandShips
approved these changes
Oct 28, 2024
AThousandShips
changed the title
Docs: Add note about C# differences in Variant constructors
Docs: Add notes about C# differences in Variant constructors
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes godotengine/godot-docs#10138.
The difference between C# and GDScipt was already noted in the
Color
default constructor. This PR adds similar notes to the other variant types with different default constructor behavior:Basis
,Projection
,Quaternion
,Transform2D
,Transform3D
.