Macros #22
Open
Macros #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…easy to translate them
… and an excel folder for the macros that resemble excel formulas.
JCZuurmond
requested changes
Mar 29, 2023
| ( | ||
| select avg({{ average_range }}) | ||
| from {{ table }} | ||
| where range = criteria |
There was a problem hiding this comment.
This is nog going to work
JCZuurmond
reviewed
Apr 12, 2023
| ["macro.dbt_excel.enforce_string"], | ||
| indirect=True, | ||
| ) | ||
| def test_enforce_string(macro_generator: MacroGenerator, config) -> None: |
There was a problem hiding this comment.
@jmperafan : Could you add more tests for the macros?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a small sample of Excel functions. I am using average as an example to create (averagea, averageif, averagex), but once they have been validated, we can do the same with other aggregations.