Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint)!: migrate all eslint configs to v9 #974

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rxmarbles
Copy link
Member

@rxmarbles rxmarbles commented Dec 21, 2024

Summary

This PR upgrades all eslint configs to use v9. I know that in eslint >= 8.23 flat config is supported however, feasibly I do not want to make these config semi backwards. Better to do the breaking change now and just keep a v8 branch for patch/bug updates. I've also removed the flow based configs. I know Flow is still around and utilized but we no longer support its use internally at GoDaddy. If there are hard opinions to this I do not mind bringing them back in this PR and migrating them to v9. I've also remove the CLI portion of these libraries as we should only be using the eslint binary directly.

The biggest question here is should be using all the custom rules we have established here or should we be leveraging the industry standards. A lot of our rules are outdated and often times conflicted with a lot of recommended configs and plugins. IMHO we should probably lean that way and allow the consumer to decide if they want to modify the rules they want to have. The config should mostly provide the additional configs and plugins (such as the react, mocha, node, ect.) doing this keep their configs small but still allows for flexibility.

Changeset

  • Changeset added (docs)

Test Plan

These have been tested locally to make

BREAKING CHANGE: This removes v8 from being supported and moves to flat config
BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config
BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config
BREAKING CHANGE: This removes eslint@v8 from support and moves to flat config
@rxmarbles rxmarbles requested a review from a team as a code owner December 21, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant