Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RANGE type unsupported #42

Open
ohaibbq opened this issue May 23, 2024 · 1 comment
Open

RANGE type unsupported #42

ohaibbq opened this issue May 23, 2024 · 1 comment

Comments

@ohaibbq
Copy link

ohaibbq commented May 23, 2024

Hi @goccy, support for the RANGE data type was added in this commit google/zetasql@5133c6e

It'd be great to update the mirrored source code and bindings to use a new version of zetasql. There are other improvements that have been made that would make some things in go-zetasqlite nicer.

What is the process for updating the mirrored source and bindings?

@ohaibbq
Copy link
Author

ohaibbq commented May 29, 2024

I was able to get the new source by running make build && make export && make update in internal/cmd/updater

The internal/cmd/updater/Dockerfile needed to be updated:

FROM golang:1.21-bookworm

RUN apt-get update && apt-get install -y --no-install-recommends curl ca-certificates gnupg
RUN curl https://bazel.build/bazel-release.pub.gpg | apt-key add -
RUN echo "deb [arch=amd64] https://storage.googleapis.com/bazel-apt stable jdk1.8" | tee /etc/apt/sources.list.d/bazel.list
RUN apt-get update && apt-get install --no-install-recommends -y make g++ git python3 openjdk-17-jdk unzip
RUN update-alternatives --install /usr/bin/python python /usr/bin/python3 100
RUN go install github.com/bazelbuild/bazelisk@latest

COPY zetasql /zetasql

WORKDIR /zetasql

RUN BAZEL_CXXOPTS="-std=c++17" bazelisk build '//zetasql/public:sql_formatter'

COPY export.sh export.sh

@goccy Are the YAMLs for bridge.yaml, config.yaml, imports.yaml written by hand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant