Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable concrete column schema nodes #30

Open
paulourio opened this issue Jul 10, 2023 · 0 comments
Open

Unreachable concrete column schema nodes #30

paulourio opened this issue Jul 10, 2023 · 0 comments

Comments

@paulourio
Copy link

paulourio commented Jul 10, 2023

In ZetaSQL, ASTColumnSchema is an abstract class, and its extensions are

  • ASTArrayColumnSchema
  • ASTInferredTypeColumnSchema
  • ASTSimpleColumnSchema
  • ASTStructColumnSchema

However, in Go bindings, we have a struct ast.ColumnSchemaNode and ast.Nodes's of kind ast.ArrayColumnSchema, ast.InferredTypeColumnSchema, ast.StructColumnSchema, and ast.StructColumnSchema are mapped to *ast.ColumnSchemaNode.
Effectively, I cannot reach any of ast.ArrayColumnSchemaNode, ast.InferredTypeColumnSchemaNode, ast.StructColumnSchemaNode, or ast.ArrayColumnSchemaNode by walking with Child() methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant