Add InterfaceCustomUnmarshaler and test case to override interface type #450
+387
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 76.02% 76.26% +0.24%
==========================================
Files 13 13
Lines 4692 4790 +98
==========================================
+ Hits 3567 3653 +86
- Misses 866 875 +9
- Partials 259 262 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #449
CustomInterfaceMarshalerandCustomInterfaceUnmarshaler.There are
Bytes(Un)MarshalerandInterface(Un)Marshalerinterface.But there is no Interface(Un)Marshaler in Custom(Un)Marshaler.
I want to use InterfaceUnmashaler as CustomUnmarshaler.
Renaming
Custom(Un)marshalertoCustomBytes(Un)marshaleris good for describing function, but it breaks backward compatibility.The linked issue has a use case and example.
Added test case corresponding to the example in the linked issue.