Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license for code copied from segmentio/encoding #475

Closed
achille-roussel opened this issue Oct 13, 2023 · 3 comments
Closed

Missing license for code copied from segmentio/encoding #475

achille-roussel opened this issue Oct 13, 2023 · 3 comments

Comments

@achille-roussel
Copy link

Hello!

I noticed that some of the code in go-json appears to have been copied or derived from work originally done in segmentio/encoding. segmentio/encoding was released under MIT license, which states the following:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

For example, the appendString function in go-json seems to be an improvement of encodeString and escapeIndex in segmentio/encoding.

Let me know if I'm mistaken, but the comments are exactly identical and the code structure very similar.

I would like to ask if you could include the original LICENSE file in go-json to satisfy the license under which the code was originally released.

@goccy
Copy link
Owner

goccy commented Oct 13, 2023

@achille-roussel Thank you for notice. It is true that the code is inspired by segmentio/encoding, so I've added the license to that file. Is it correct ? #476

@achille-roussel
Copy link
Author

Yes, that's perfect 👍

Sometimes projects also dedicate a folder to hold the licenses of third-party code that they have integrated, but that's really up to you on how you prefer to manage those.

Thanks for taking the time to address this issue!

@goccy
Copy link
Owner

goccy commented Oct 13, 2023

Thank you for telling me about this. Merged.

@goccy goccy closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants