-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ldv regression benchmarks to incremental benchmarks #35
Draft
jerhard
wants to merge
13
commits into
master
Choose a base branch
from
incremental_ldv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntal ldv benchmarks
…bench_incremental.rb
Would be useful to have a CIL issue about this parsing error. |
Iirc they were actually errors (the type of the implementation not matching the one given in the prototype in the same file) etc that GCC also flags. If we want to do something here, I don't think we should patch CIL to accept invalid programs, but rather fix the benchmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports benchmarks that were taken from https://gitlab.com/sosy-lab/software/regression-verification-tasks/-/tree/new-svcomp-spec. Further information on these benchmarks can be found here.
The benchmarks were processed with
incremental-ldv.py
to generate the patch files and create the benchmark sets inindex/sets/ldv/
. The fileindex/sets/ldv/combined.yaml
contains all benchmarks that are imported; the otheryaml
files inindex/sets/ldv/
contain the benchmarks per directory.Problems
There are some significant problems with this benchmark set. In particular: