-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/docs: Add AdventureLog Community Integration Documentation #12928
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @seanmorley15 ; Thanks for your contribution to authentik! I noticed a few things that would necessitate your review, once that's done I'll be happy to take another look at this PR. Please do let me know if you have any questions.
Hi @dominic-r, thanks so much for taking the time to review! I just made the changes you suggested. Let me know if there is anything else that should be changed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @seanmorley15 Thanks for your time. Here are some things I noticed in this second review. Nothing major, just some nit-picks. Thanks
cc @tanberry when you have a second for additional review / merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12928 +/- ##
==========================================
- Coverage 92.72% 92.69% -0.03%
==========================================
Files 770 785 +15
Lines 38945 39623 +678
==========================================
+ Hits 36113 36730 +617
- Misses 2832 2893 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks so much for taking the time to review @dominic-r! I think it should be all set now! Any other changes after a final review @tanberry? Thanks all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @seanmorley15 for this contribution! Thanks for adding the Troubleshooting section, always nice to have that. A couple of edits, then let's get this merged...
…reation and validation
Ok, just went and fixed it based on your review! Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution to authentik!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mangled my own review
* main: web/user: fix opening application with Enter not respecting new tab setting (#13115) web: bump API Client version (#13113) providers/rac: move to open source (#13015) website/docs: add 2025.2 release notes (#13002) core: clear expired database sessions (#13105) core: bump sentry-sdk from 2.21.0 to 2.22.0 (#13098) core: bump bandit from 1.8.2 to 1.8.3 (#13097) core: bump aws-cdk-lib from 2.178.2 to 2.179.0 (#13099) core: bump goauthentik.io/api/v3 from 3.2024123.4 to 3.2024123.6 (#13100) lifecycle/aws: bump aws-cdk from 2.178.2 to 2.179.0 in /lifecycle/aws (#13101) website/docs: Add AdventureLog Community Integration Documentation (#12928) website/docs: minor fixes (#13095) website/integrations: Update to Wizard and Styling Guide (#12919) web: bump API Client version (#13093) policies/geoip: distance + impossible travel (#12541) root: fix generated API docs not being excluded from codespell (#13091)
Details
Adds documentation for an AdventureLog community integration.
Checklist
make website
)