Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: Add AdventureLog Community Integration Documentation #12928

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

seanmorley15
Copy link
Contributor

Details

Adds documentation for an AdventureLog community integration.


Checklist

  • The documentation has been updated
  • The documentation has been formatted (make website)

@seanmorley15 seanmorley15 requested a review from a team as a code owner February 3, 2025 23:48
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit e7de504
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67b0b562f8bcdb0009ec0e7b
😎 Deploy Preview https://deploy-preview-12928--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit e7de504
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67b0b562f8bcdb0009ec0e79
😎 Deploy Preview https://deploy-preview-12928--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seanmorley15 ; Thanks for your contribution to authentik! I noticed a few things that would necessitate your review, once that's done I'll be happy to take another look at this PR. Please do let me know if you have any questions.

@seanmorley15
Copy link
Contributor Author

Hi @dominic-r, thanks so much for taking the time to review! I just made the changes you suggested. Let me know if there is anything else that should be changed!

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seanmorley15 Thanks for your time. Here are some things I noticed in this second review. Nothing major, just some nit-picks. Thanks

@dominic-r
Copy link
Contributor

cc @tanberry when you have a second for additional review / merge

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (7686d12) to head (e7de504).
Report is 121 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12928      +/-   ##
==========================================
- Coverage   92.72%   92.69%   -0.03%     
==========================================
  Files         770      785      +15     
  Lines       38945    39623     +678     
==========================================
+ Hits        36113    36730     +617     
- Misses       2832     2893      +61     
Flag Coverage Δ
e2e 48.40% <ø> (-0.15%) ⬇️
integration 24.54% <ø> (-0.06%) ⬇️
unit 90.43% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seanmorley15
Copy link
Contributor Author

Thanks so much for taking the time to review @dominic-r! I think it should be all set now! Any other changes after a final review @tanberry? Thanks all!

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seanmorley15 for this contribution! Thanks for adding the Troubleshooting section, always nice to have that. A couple of edits, then let's get this merged...

@rissson rissson changed the title docs: Add AdventureLog Community Integration Documentation website/docs: Add AdventureLog Community Integration Documentation Feb 13, 2025
@seanmorley15
Copy link
Contributor Author

seanmorley15 commented Feb 15, 2025

Ok, just went and fixed it based on your review! Let me know what you think!
Thanks a lot @tanberry

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution to authentik!

@tanberry tanberry self-requested a review February 17, 2025 20:58
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mangled my own review

@tanberry tanberry merged commit 28485e8 into goauthentik:main Feb 18, 2025
69 checks passed
kensternberg-authentik added a commit that referenced this pull request Feb 20, 2025
* main:
  web/user: fix opening application with Enter not respecting new tab setting (#13115)
  web: bump API Client version (#13113)
  providers/rac: move to open source (#13015)
  website/docs: add 2025.2 release notes (#13002)
  core: clear expired database sessions (#13105)
  core: bump sentry-sdk from 2.21.0 to 2.22.0 (#13098)
  core: bump bandit from 1.8.2 to 1.8.3 (#13097)
  core: bump aws-cdk-lib from 2.178.2 to 2.179.0 (#13099)
  core: bump goauthentik.io/api/v3 from 3.2024123.4 to 3.2024123.6 (#13100)
  lifecycle/aws: bump aws-cdk from 2.178.2 to 2.179.0 in /lifecycle/aws (#13101)
  website/docs: Add AdventureLog Community Integration Documentation (#12928)
  website/docs: minor fixes (#13095)
  website/integrations: Update to Wizard and Styling Guide (#12919)
  web: bump API Client version (#13093)
  policies/geoip: distance + impossible travel (#12541)
  root: fix generated API docs not being excluded from codespell (#13091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants