-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sources: prevent deletion of built-in source #12914
base: main
Are you sure you want to change the base?
sources: prevent deletion of built-in source #12914
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12914 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 785 785
Lines 39580 39586 +6
=======================================
+ Hits 36711 36719 +8
+ Misses 2869 2867 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dominic R <[email protected]>
Signed-off-by: Dominic R <[email protected]>
Hi @BeryJu. Sorry to bother. Do you think you could take a look at this when you have a second? Thanks |
sdko/sources/no-delete-built-in
What?
This PR modifies
renderToolbarSelected
to disable the "Delete" button for the built-in authentik login source. While the source will reappear after a server restart, the change is intended as a precaution to prevent potential issues by blocking deletion. Furthermore, it adds a function to theSourceViewSet
class to return an error when attmpting to delete the source using the API url.Testing:
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)