website/integrations: proxmox: cleanup guide #11894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the guide to explicitly state the path to the Providers tab. Signed-off-by: 4d62 <[email protected]>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11894 +/- ##
==========================================
- Coverage 92.75% 92.69% -0.07%
==========================================
Files 767 767
Lines 38522 38522
==========================================
- Hits 35733 35709 -24
- Misses 2789 2813 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cleans up instructions to make them more readable Signed-off-by: 4d62 <[email protected]>
dominic-r
changed the title
added 3 commits
November 2, 2024 21:57
Specifies the location of the Applications tab in the admin interface Signed-off-by: 4d62 <[email protected]>
Some instructions were copied over in my previous commit and were never removed. This commit removes redundant instructions Signed-off-by: 4d62 <[email protected]>
Touch up a few things to try to make it match Signed-off-by: 4d62 <[email protected]>
|
cc @tanberry for review |
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
reviewed
Nov 11, 2024
tanberry
requested changes
Nov 11, 2024
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Signed-off-by: 4d62 <[email protected]>
|
first time doing this in a while, i forgot a bunch of things 🤣 |
added 2 commits
November 11, 2024 20:11
Address review comment goauthentik#11894 (comment) - Merge lines 42 and 44 Signed-off-by: 4d62 <[email protected]>
run `npx prettier --write website/integrations/services/proxmox-ve/index.md`
|
@tanberry would you mind also checking this one out again? thanks |
tanberry
reviewed
Dec 3, 2024
tanberry
reviewed
Dec 3, 2024
tanberry
requested changes
Dec 3, 2024
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
|
@tanberry should be good |
|
hi @tanberry . would it be possible to take a final look at this? thanks |
tanberry
approved these changes
Dec 16, 2024
|
Thank you so much @4d62 both for this contribution and for your patience. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the setup guide
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)