feat: non-latin keyboard layout compatible shortcuts #2116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The keyboard shortcuts requires using a Latin-based keyboard layout.
For example,
Ctrl+kon the Russian layout would result inCtrl+л.Assumptions
event.codeinstead ofevent.key, as it discussed hereKeyboardEventdue to possible browser-specific troubles and the security reasonsSolution
Duplicate all the hotkeys for language-specific variants based on provided language key maps such as
{ k: 'л' }for the Russian example. This PR contains the Russian hotkey map and the functionality to add more.Concerns
event.codeapproach