Skip to content

Conversation

@ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jan 8, 2026

Helpful addition for platforms that have strict secret storage policies / strategies

@ecrupper ecrupper requested a review from a team as a code owner January 8, 2026 14:18
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 66.31579% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.37%. Comparing base (0ea4d84) to head (8021cf1).

Files with missing lines Patch % Lines
router/middleware/perm/perm.go 45.94% 16 Missing and 4 partials ⚠️
api/admin/settings.go 0.00% 6 Missing ⚠️
api/types/settings/platform.go 84.61% 6 Missing ⚠️

❌ Your project check has failed because the head coverage (58.37%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   58.36%   58.37%   +0.01%     
==========================================
  Files         645      645              
  Lines       24864    24931      +67     
==========================================
+ Hits        14511    14554      +43     
- Misses       9681     9701      +20     
- Partials      672      676       +4     
Files with missing lines Coverage Δ
cmd/vela-server/flags.go 100.00% <ø> (ø)
database/settings/table.go 100.00% <ø> (ø)
database/types/settings.go 65.04% <100.00%> (+1.79%) ⬆️
mock/server/settings.go 0.00% <ø> (ø)
api/admin/settings.go 0.00% <0.00%> (ø)
api/types/settings/platform.go 77.12% <84.61%> (+1.95%) ⬆️
router/middleware/perm/perm.go 59.62% <45.94%> (-1.82%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wass3rw3rk
wass3rw3rk previously approved these changes Jan 8, 2026
}

// MustSecretAdmin ensures the user has admin access to the org, repo or team.
func MustSecretAdmin() gin.HandlerFunc {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add comment to deal with Function 'MustSecretAdmin' is too long (174 > 160) (funlen) or break up func?

plyr4
plyr4 previously approved these changes Jan 8, 2026
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, random thought but showing a pipeline warning when someone uses them while theyre disabled might be cool

@ecrupper
Copy link
Contributor Author

ecrupper commented Jan 8, 2026

nice, random thought but showing a pipeline warning when someone uses them while theyre disabled might be cool

Good idea but the pipeline will just fail completely because the worker won't be able to retrieve the secret, so I think that will serve as enough of a warning 😅

@ecrupper ecrupper dismissed stale reviews from plyr4 and wass3rw3rk via 0836951 January 8, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants