-
Notifications
You must be signed in to change notification settings - Fork 30
feat: platform setting for enabling/disabling Vela secrets #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (58.37%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
+ Coverage 58.36% 58.37% +0.01%
==========================================
Files 645 645
Lines 24864 24931 +67
==========================================
+ Hits 14511 14554 +43
- Misses 9681 9701 +20
- Partials 672 676 +4
🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| // MustSecretAdmin ensures the user has admin access to the org, repo or team. | ||
| func MustSecretAdmin() gin.HandlerFunc { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add comment to deal with Function 'MustSecretAdmin' is too long (174 > 160) (funlen) or break up func?
plyr4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, random thought but showing a pipeline warning when someone uses them while theyre disabled might be cool
Good idea but the pipeline will just fail completely because the worker won't be able to retrieve the secret, so I think that will serve as enough of a warning 😅 |
Helpful addition for platforms that have strict secret storage policies / strategies