Enforce validation for taskfile field in includes

task_test.go

@@ -1706,6 +1706,35 @@
 	}
 }
 
+func TestIncludesInvalidTaskfile(t *testing.T) {
+	const dir = "testdata/includes_invalid_taskfile"
+
+	tests := []struct {
+		name        string
+		expectedErr string
+	}{
+		{"include_empty_taskfile", "taskfile field in the include cannot be empty"},
+		{"include_empty_value", "taskfile of the include cannot be empty"},
+		{"include_missing_taskfile", "taskfile field in the include cannot be null"},
+		{"include_null_taskfile", "taskfile field in the include cannot be null"},
+		{"include_null_value", "value of the include cannot be null"},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			var buff bytes.Buffer
+			e := task.Executor{
+				Dir:    filepath.Join(dir, test.name),
+				Stdout: &buff,
+				Stderr: &buff,
+				Silent: true,
+			}
+			err := e.Setup()
+			assert.ErrorContains(t, err, test.expectedErr)
+		})
+	}
+}
+
 func TestIncludesWithExclude(t *testing.T) {
 	t.Parallel()
 

taskfile/ast/include.go

@@ -113,6 +113,11 @@ func (includes *Includes) UnmarshalYAML(node *yaml.Node) error {
 			keyNode := node.Content[i]
 			valueNode := node.Content[i+1]
 
+			// Ensure the include value is not null, as it must be either a string or an include object.
+			if valueNode.Kind == yaml.ScalarNode && valueNode.Tag == "!!null" {
+				return errors.NewTaskfileDecodeError(nil, valueNode).WithMessage("value of the include cannot be null")
+			}
+
 			// Decode the value node into an Include struct
 			var v Include
 			if err := valueNode.Decode(&v); err != nil {
@@ -133,18 +138,20 @@ func (includes *Includes) UnmarshalYAML(node *yaml.Node) error {
 
 func (include *Include) UnmarshalYAML(node *yaml.Node) error {
 	switch node.Kind {
-
 	case yaml.ScalarNode:
 		var str string
 		if err := node.Decode(&str); err != nil {
 			return errors.NewTaskfileDecodeError(err, node)
 		}
+		if str == "" {
+			return errors.NewTaskfileDecodeError(nil, node).WithMessage("taskfile of the include cannot be empty")
+		}
 		include.Taskfile = str
 		return nil
 
 	case yaml.MappingNode:
 		var includedTaskfile struct {
-			Taskfile string
+			Taskfile *string
 			Dir      string
 			Optional bool
 			Internal bool
@@ -156,7 +163,13 @@ func (include *Include) UnmarshalYAML(node *yaml.Node) error {
 		if err := node.Decode(&includedTaskfile); err != nil {
 			return errors.NewTaskfileDecodeError(err, node)
 		}
-		include.Taskfile = includedTaskfile.Taskfile
+		if includedTaskfile.Taskfile == nil {
+			return errors.NewTaskfileDecodeError(nil, node).WithMessage("taskfile field in the include cannot be null")
+		}
+		if *includedTaskfile.Taskfile == "" {
+			return errors.NewTaskfileDecodeError(nil, node).WithMessage("taskfile field in the include cannot be empty")
+		}
+		include.Taskfile = *includedTaskfile.Taskfile
 		include.Dir = includedTaskfile.Dir
 		include.Optional = includedTaskfile.Optional
 		include.Internal = includedTaskfile.Internal

testdata/includes_invalid_taskfile/include_empty_taskfile/Taskfile.yml

@@ -0,0 +1,10 @@
+version: '3'
+
+includes:
+  included:
+    taskfile: ''
+
+tasks:
+  default:
+    cmds:
+      - task: included:default

testdata/includes_invalid_taskfile/include_empty_value/Taskfile.yml

@@ -0,0 +1,9 @@
+version: '3'
+
+includes:
+  included: ''
+
+tasks:
+  default:
+    cmds:
+      - task: included:default

testdata/includes_invalid_taskfile/include_missing_taskfile/Taskfile.yml

@@ -0,0 +1,10 @@
+version: '3'
+
+includes:
+  included:
+    dir: '.'
+
+tasks:
+  default:
+    cmds:
+      - task: included:default

testdata/includes_invalid_taskfile/include_null_taskfile/Taskfile.yml

@@ -0,0 +1,10 @@
+version: '3'
+
+includes:
+  included:
+    taskfile: null
+
+tasks:
+  default:
+    cmds:
+      - task: included:default

testdata/includes_invalid_taskfile/include_null_value/Taskfile.yml

@@ -0,0 +1,9 @@
+version: '3'
+
+includes:
+  included: null
+
+tasks:
+  default:
+    cmds:
+      - task: included:default

website/static/schema.json

@@ -621,14 +621,16 @@
             "^.*$": {
               "anyOf": [
                 {
-                  "type": "string"
+                  "type": "string",
+                  "minLength": 1
                 },
                 {
                   "type": "object",
                   "properties": {
                     "taskfile": {
                       "description": "The path for the Taskfile or directory to be included. If a directory, Task will look for files named `Taskfile.yml` or `Taskfile.yaml` inside that directory. If a relative path, resolved relative to the directory containing the including Taskfile.",
-                      "type": "string"
+                      "type": "string",
+                      "minLength": 1
                     },
                     "dir": {
                       "description": "The working directory of the included tasks when run.",
@@ -664,7 +666,8 @@
                       "description": "A set of variables to apply to the included Taskfile.",
                       "$ref": "#/definitions/vars"
                     }
-                  }
+                  },
+                  "required": ["taskfile"]
                 }
               ]
             }