feat(remote): add tests for git remote taskfiles #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a similar approach as the HTTP remote taskfile tests, leveraging the `git` tool's built-in support for hosting a local HTTP server via CGI.
pbitty
commented
Oct 29, 2024
Comment on lines
+1094
to
+1096
| if !gitSupported { | ||
| t.Log("git tests not supported and will be skipped") | ||
| } |
There was a problem hiding this comment.
I put this as a guard for now, but I would expect pretty much every CI and dev environment will have git installed. If you all agree, I will remove this guard to reduce noise in the code.
|
I'm going to mark this as draft while I sort out the CI issues. I need to find the right git ref to use. |
|
Ok, fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a similar approach as the HTTP remote taskfile tests,
leveraging the
gittool's built-in support for hosting a local HTTPserver via CGI.
I was inspired by the HTTP tests and realized the same thing could work for git.