Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: formatToJSFunc use string plus #1101

Merged
merged 1 commit into from
Aug 19, 2024
Merged

opt: formatToJSFunc use string plus #1101

merged 1 commit into from
Aug 19, 2024

Conversation

somnus-L
Copy link
Contributor

Development guide

Link

Test on local before making the PR

go run ./lib/utils/simple-check

when I use pprof analyze memory , I found this :
image
so, I use string plus instead fmt.Sprintf

@ysmood
Copy link
Member

ysmood commented Aug 16, 2024

If you want extreme performance, you can even use a sync.Pool here to reduce memory allocation and deallocation overhead.

@ysmood ysmood merged commit 0096e53 into go-rod:main Aug 19, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants