fix flaky test

go-rod · Jul 6, 2024 · dc1fbfc · dc1fbfc
1 parent 1bc7792
commit dc1fbfc
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/page_test.go b/page_test.go
@@ -100,7 +100,7 @@ func TestSetExtraHeaders(t *testing.T) {
 
  wg := sync.WaitGroup{}
  var header http.Header
- s.Mux.HandleFunc("/", func(_ http.ResponseWriter, r *http.Request) {
+ s.Mux.HandleFunc("/set-header", func(_ http.ResponseWriter, r *http.Request) {
  header = r.Header
  wg.Done()
  })
@@ -109,23 +109,20 @@ func TestSetExtraHeaders(t *testing.T) {
  cleanup := p.MustSetExtraHeaders("a", "1", "b", "2")
 
  wg.Add(1)
- p.MustNavigate(s.URL())
+ p.MustNavigate(s.URL("/set-header"))
  wg.Wait()
 
  g.Eq(header.Get("a"), "1")
  g.Eq(header.Get("b"), "2")
 
  cleanup()
 
- // TODO: I don't know why it will fail randomly
- if false {
- wg.Add(1)
- p.MustReload()
- wg.Wait()
+ wg.Add(1)
+ p.MustReload()
+ wg.Wait()
 
- g.Eq(header.Get("a"), "")
- g.Eq(header.Get("b"), "")
- }
+ g.Eq(header.Get("a"), "")
+ g.Eq(header.Get("b"), "")
 }
 
 func TestSetUserAgent(t *testing.T) {
@@ -892,7 +889,7 @@ func TestFonts(t *testing.T) {
 func TestPagePDF(t *testing.T) {
  g := setup(t)
 
- p := g.page.MustNavigate(g.srcFile("fixtures/click.html"))
+ p := g.newPage(g.srcFile("fixtures/click.html"))
 
  s, err := p.PDF(&proto.PagePrintToPDF{})
  g.E(err)