Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary request cycle on non-idempotent methods #777 #896

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jeevatkm
Copy link
Member

No description provided.

@jeevatkm jeevatkm added bug v3 For resty v3 labels Oct 28, 2024
@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone Oct 28, 2024
@jeevatkm jeevatkm self-assigned this Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (c6cf259) to head (8e1518b).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.15%   98.03%   -0.12%     
==========================================
  Files          14       16       +2     
  Lines        2329     3156     +827     
==========================================
+ Hits         2286     3094     +808     
- Misses         23       42      +19     
  Partials       20       20              
Flag Coverage Δ
unittests 98.03% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit d34f128 into main Oct 28, 2024
6 checks passed
@jeevatkm jeevatkm deleted the fix-request-cycle branch October 28, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug v3 For resty v3
Development

Successfully merging this pull request may close these issues.

1 participant