Add MariaDB to CI configuration #307
Conversation
|
@tabarnhack But those changes are not enough to actually test agains MariaDB – you have to change Makefile too |
There was no test step about Mariadb in the Makefile. 2 have been added to mimic the tests performed on MySQL. Moreover, the docker-compose file has been altered in order to add the MariaDB image. As MariaDB and MySQL are similar, the listening port for the first one has been moved from 3306 to 6033 to prevent any conflict. The connection strings have been modified to take the change into account.
|
Indeed, I did not read the codebase enough to understand where the tests was made. |
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 68.57% 68.57%
=======================================
Files 20 20
Lines 1715 1715
=======================================
Hits 1176 1176
Misses 484 484
Partials 55 55 Continue to review full report at Codecov.
|
Makefile
Outdated
| mariadb-traditional: export REFORM_TEST_ADMIN_SOURCE = root@tcp(localhost:6033)/mysql | ||
| mariadb-traditional: export REFORM_TEST_INIT_SOURCE = root@tcp(localhost:6033)/reform-database?parseTime=true&clientFoundRows=true&time_zone='UTC'&sql_mode='ANSI'&multiStatements=true | ||
| mariadb-traditional: export REFORM_TEST_SOURCE = root@tcp(localhost:6033)/reform-database?parseTime=true&clientFoundRows=true&time_zone='America%2FNew_York'&sql_mode='TRADITIONAL'&interpolateParams=true | ||
| mariadb-traditional: export REFORM_TEST_COVER=mysql |
There was a problem hiding this comment.
| mariadb-traditional: export REFORM_TEST_COVER=mysql | |
| mariadb-traditional: export REFORM_TEST_COVER=mariadb |
The same for mariadb-traditional
There was a problem hiding this comment.
I didn't change as the syntax between the 2 projects has a great compatibility and SQL scripts should run seemlessly on MySQL as well as MariaDB (source: MariaDB vs MySQL). Otherwise, it would have been duplicating the mysql scripts and renaming as mariadb.
This duplicate produced a warning while running make
According to #257, MariaDB has been added to CI configuration.
The minimal version taken of MariaDB is
10.2as the10.1has an EOL on October 2020, thus this version is obsolete.