fix: change error type from ErrUnauthorizedClient to ErrUnsupportedGrantType for unsupported grant types #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antType Update GetAccessToken function to return more appropriate error type for unsupported grant type scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an incorrect error type returned when an unsupported grant type is encountered in the OAuth2 server.
Changes
ErrUnauthorizedClienttoErrUnsupportedGrantTypeinGetAccessTokenfunctionFiles Modified
server/server.go: Updated error return value in line 396Why This Change?
The previous error type
ErrUnauthorizedClientwas semantically incorrect for cases where the grant type itself is not supported. According to OAuth2 specifications,unsupported_grant_typeis the appropriate error code for this scenario.Testing
Impact