Update Marshal to use strings.Builder #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2022 16:21
Before: Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -bench ^BenchmarkMarshalNEntries$ github.com/go-ldap/ldif goos: linux goarch: amd64 pkg: github.com/go-ldap/ldif cpu: Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz BenchmarkMarshalNEntries/marshal_100-12 1000000000 0.001498 ns/op 0 B/op 0 allocs/op BenchmarkMarshalNEntries/marshal_1000-12 1000000000 0.1485 ns/op 0 B/op 0 allocs/op BenchmarkMarshalNEntries/marshal_10000-12 111295240700 ns/op 94516468448 B/op 349306 allocs/op PASS ok github.com/go-ldap/ldif 13.154s
Looks like at least 2 orders of magnitude improvement at 1000 entries After: Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -bench ^BenchmarkMarshalNEntries$ github.com/go-ldap/ldif goos: linux goarch: amd64 pkg: github.com/go-ldap/ldif cpu: Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz BenchmarkMarshalNEntries/marshal_100-12 1000000000 0.0001769 ns/op 0 B/op 0 allocs/op BenchmarkMarshalNEntries/marshal_1000-12 1000000000 0.001784 ns/op 0 B/op 0 allocs/op BenchmarkMarshalNEntries/marshal_10000-12 1000000000 0.02262 ns/op 0 B/op 0 allocs/op BenchmarkMarshalNEntries/marshal_100000-12 1000000000 0.2143 ns/op 0 B/op 0 allocs/op PASS ok github.com/go-ldap/ldif 3.329s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #6, but a smaller modification, added benchmarks, and should make it past the CI. The benchmarks show a pretty significant improvement:
Before:
After:
Without this (or similar patch), ldif marshaling is basically unusable for a reasonably sized directory.