Fix DATA RACE as a result of changing ber's module global variable for fuzz tests #473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated why DATA RACE occurred.
Fuzz tests also run as unit tests, so the module global variable shouldn't change in a test function.
I fix this conflict by adding TestMain(), which handles a setup process before all tests. Now, all tests run with
ber.MaxPacketLengthBytes
limitation. Does it make sense?See also #472.
References