Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven pom inheritance #32943

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

wxiaoguang
Copy link
Contributor

Fix #30568

At the moment, here only GroupID (no Version) is parsed & used

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 22, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 22, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 22, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Dec 22, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 22, 2024
@JSchlarb
Copy link

Just a quick remark from my side: This appears very similar to the fix from Forgejo. Since versions are determined via the path parameter and not from the XML property, there doesn't seem to be a need to inherit the version from the parent. How would you handle parsing something like this: <version>${revision}${changelist}${sha1}</version>?

@wxiaoguang
Copy link
Contributor Author

Since versions are determined via the path parameter and not from the XML property, there doesn't seem to be a need to inherit the version from the parent. How would you handle parsing something like this: <version>${revision}${changelist}${sha1}</version>?

Not supported yet?

@JSchlarb
Copy link

It's totally okay to rely on the version provided by Maven as a path parameter, as it can contain parameters and be overridden by Maven using command-line options, such as mvn deploy -Dsha1=f75ed7510f.

https://maven.apache.org/maven-ci-friendly.html

@wxiaoguang wxiaoguang requested a review from Zettat123 December 23, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.23 lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing groupId in maven packages (<parent> section in pom.xml files not consulted for groupId or version)
4 participants