Skip to content

Use new mail package instead of an unmintained one #32682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 10 commits into from
Dec 4, 2024
Merged

Use new mail package instead of an unmintained one #32682

lunny merged 10 commits into from
Dec 4, 2024

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 30, 2024

Resolve #18664

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 30, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/dependencies labels Nov 30, 2024
@lunny lunny mentioned this pull request Nov 30, 2024
Merged
@Neustradamus Neustradamus mentioned this pull request Dec 1, 2024
Closed
@Neustradamus
Copy link

Neustradamus commented Dec 1, 2024

@lunny: Excellent, good job if all devs were like you! :)
Hope that the team will review quickly and release a new build asap ^^

Linked to:

@lunny lunny force-pushed the lunny/replace_mail2 branch from d4e19a8 to 220285f Compare December 4, 2024 04:06
@lunny lunny marked this pull request as ready for review December 4, 2024 04:34
@lunny lunny requested a review from techknowlogick December 4, 2024 04:40
@yp05327 yp05327 self-requested a review December 4, 2024 04:46
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2024
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 4, 2024
@lunny lunny merged commit 5ab7aa7 into go-gitea:main Dec 4, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 4, 2024
@lunny lunny deleted the lunny/replace_mail2 branch December 4, 2024 22:33
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 4, 2024
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Dec 4, 2024
@Neustradamus
Copy link

Neustradamus commented Dec 4, 2024

@lunny: Good job, thanks!

zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 5, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c172d7c 
* giteaofficial/main:
  Fix fork page branch selection (go-gitea#32711)
  Add Arch package registry (go-gitea#32692)
  Use new mail package instead of an unmintained one (go-gitea#32682)
  Fix mentionable users when writing issue comments (go-gitea#32715)
  Fix file editor & preview (go-gitea#32706)
  Remove outdated code about fixture generation (go-gitea#32708)
  Fix gogit `GetRefCommitID` (go-gitea#32705)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 4, 2025
wxiaoguang
wxiaoguang reviewed Dec 12, 2025
View reviewed changes
services/mailer/sender/sender.go
}

// TODO: implement sending from multiple addresses
if err := sender.Send(froms[0].Address, to, m); err != nil {
Copy link
Contributor

@wxiaoguang wxiaoguang Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It causes panics like "Panic during startup #35768"

I don't know why the froms can be empty. Maybe you can figure out the root cause and/or improve " Fix various bugs #36139" / add more comments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lafriks lafriks lafriks approved these changes

@wolfogre wolfogre wolfogre approved these changes

@delvh delvh delvh approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

@yp05327 yp05327 Awaiting requested review from yp05327

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

gomail library unmaintained

7 participants

@lunny @Neustradamus @lafriks @wxiaoguang @wolfogre @delvh @GiteaBot