Validate OAuth Redirect URIs #32643
Open
Validate OAuth Redirect URIs #32643
+299
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
lunny
reviewed
Nov 26, 2024
modules/validation/binding.go
Outdated
| // URL validation rule | ||
| binding.AddRule(&binding.Rule{ | ||
| IsMatch: func(rule string) bool { | ||
| return strings.HasPrefix(rule, "ValidUrlList") |
There was a problem hiding this comment.
Suggested change
| return strings.HasPrefix(rule, "ValidUrlList") | |
| return strings.EqualFold(rule, "ValidUrlList") |
There was a problem hiding this comment.
But "why"?
Shouldn't we be strict for names?
There was a problem hiding this comment.
If we want a strict name, it should be == here. But I don't think HasPrefix is right here. For other examples, some maybe also not be right and some are for xxx( so they use HasPrefix.
There was a problem hiding this comment.
I agree, but why it was changed to EqualFold?
There was a problem hiding this comment.
I misunderstood how other rules implemented. I thought case insensitive seems reasonable. Now I think we should follow the old styles to keep consistency.
lunny
reviewed
Nov 26, 2024
lunny
approved these changes
Nov 27, 2024
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/blocked
|
Feel free to discard my change request if the concern is addressed, in case I am not at computer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a TODO in the code to validate the RedirectURIs when adding or editing an OAuth application in user settings.
This also includes a refactor of the user settings tests to only create the DB once per top-level test to avoid reloading fixtures.