Support optional/configurable IAMEndpoint for Minio Client (#32581) #32581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using a constant IP address
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
mowoc-ocp
changed the title
wxiaoguang
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Looks good.
by the way, "app.example.ini" and related documents https://gitea.com/gitea/docs/pulls also need to update 🙏
GiteaBot
added
lgtm/need 1
lunny
reviewed
Nov 21, 2024
lunny
approved these changes
Nov 21, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wxiaoguang
removed
the
reviewed/wait-merge
Wait for config example update before merge. If there is any difficulty, maintainers could also help. |
lunny
added
reviewed/wait-merge
|
@wxiaoguang thank you for the feedback, I'll take care of the documentation PR today! |
… into minioIamDiscoverySupport
github-actions
bot
added
the
docs-update-needed
|
Added the requested updates for Let me know if there is any feedback on documentation structure or anywhere I missed that I also need to update. Thanks! |
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
lunny
added
the
reviewed/wait-merge
|
@mowoc-ocp please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 23, 2024
* giteaofficial/main: Support optional/configurable IAMEndpoint for Minio Client (go-gitea#32581) (go-gitea#32581) Update the list of watchers and stargazers when clicking watch/unwatch or star/unstar (go-gitea#32570) Apply to became a maintainer (go-gitea#32614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting issue #32271
This modification allows native Kubernetes + AWS (EKS) authentication with the Minio client, to Amazon S3 using the IRSA role assigned to a Service account by replacing the hard coded reference to the
DefaultIAMRoleEndpointwith an optional configurable endpoint.Internally, Minio's
credentials.IAMprovider implements a discovery flow for IAM Endpoints if it is not set.For backwards compatibility:
IamEndpointto retain the unit test safety inminio_test.go.http://169.254.169.254default endpoint that was being hard coded beforeTo test, we were able to build a docker image from source and, observe it choosing the expected IAM endpoint, and see files uploaded via the client.